Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8256202

Some tweaks for jarsigner tests PosixPermissionsTest and SymLinkTest

    XMLWordPrintable

Details

    Backports

      Description

        Working on 11u backports of JDK-8218021 and JDK-8250968, I found some minor points for improvement in tests
        test/jdk/sun/security/tools/jarsigner/PosixPermissionsTest.java and
        test/jdk/sun/security/tools/jarsigner/SymLinkTest.java

        The details

        PosixPermissionsTest:
        - it can run on any system, no matter if the default filesystem supports Posix or not since Posix support is only required for the zipfs which is always true.
        - improve some comments for the test flow

        SymLinkTest:
        - make output of createByteArray prettier
        - improve inline comments to ease understanding
        - add an option to main for generating ZIPBYTES
        - use "Files.write(Path.of(ZIPFILENAME), ZIPBYTES)" for creating the test zipfile

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8273718 Some tweaks for jarsigner tests PosixPermissionsTest and SymLinkTest

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8276155 Some tweaks for jarsigner tests PosixPermissionsTest and SymLinkTest

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            relates to

            Bug - A problem which impairs or prevents the functions of the product. JDK-8250968 Symlinks attributes not preserved when using jarsigner on zip files

            • P3 - Major loss of function.
            • Resolved

            Enhancement - null JDK-8218021 Have jarsigner preserve posix permission attributes

            • P3 - Major loss of function.
            • Resolved
            links to

            Commit Commit openjdk/jdk11u-dev/1c90fe05

            Commit Commit openjdk/jdk/1e9a432d

            Review Review openjdk/jdk11u-dev/564

            Review Review openjdk/jdk/1166

            Activity

              People

                clanger Christoph Langer
                clanger Christoph Langer
                Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: