Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8256810

Incremental rebuild broken on Macosx

XMLWordPrintable

    • b27
    • os_x

        After fixing JDK-8256751, I noticed that the fix-deps-file macro isn't actually doing the right thing at all. It seems clang on Macosx is inconsistent with outputting relative or absolute paths in the deps files, so some files end up with double WORKSPACE_ROOT in the paths. It's also not handling the trailing slash after WORKSPACE_ROOT correctly, so some files is missing the slash between WORKSPACE_ROOT and the original relative path.

        I'm sure I tested the behavior after fixing JDK-8256751, but after having inspected the generated deps files, I have no idea how this could have ever worked.

        This is mostly a problem on Macosx, where we do the relative path rewrite for release builds. On Linux there is compiler support to rewrite absolute paths, so this isn't an issue as long as you are using a modern enough compiler.

              erikj Erik Joelsson
              erikj Erik Joelsson
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Created:
                Updated:
                Resolved: