Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8257563

Remove excessive include of klass.inline.hpp

    XMLWordPrintable

Details

    • Enhancement
    • Resolution: Fixed
    • P4
    • 16
    • None
    • hotspot
    • b28

    Description

      klass.inline.hpp is unnecessarily included by two popular header files:

      https://github.com/openjdk/jdk/blob/fe5cccc1ec76a5c29b1f55af311823f84483395b/src/hotspot/share/oops/oop.inline.hpp#L34

      https://github.com/openjdk/jdk/blob/fe5cccc1ec76a5c29b1f55af311823f84483395b/src/hotspot/share/gc/shared/modRefBarrierSet.inline.hpp#L31

      These two lines recursively pull in many header files. Removing them reduced the total number of header inclusion for building HotSpot from 260096 to 254773, or about 2%.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. JDK-8257673 Build fails without shenandoahgc after JDK-8257563

          • P2 - Crashes, loss of data, severe memory leak.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JDK-8257743 Minimal build on AArch64 failed with --disable-precompiled-headers

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          links to

          Commit Commit openjdk/jdk/02a0a027

          Review Review openjdk/jdk/1552

          Activity

            People

              iklam Ioi Lam
              iklam Ioi Lam
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: