Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8258004

Remove unnecessary inclusion of vm_version.hpp

    XMLWordPrintable

Details

    • Enhancement
    • Status: Resolved
    • P4
    • Resolution: Fixed
    • 17
    • 17
    • hotspot
    • b06

    Description

      In the x86 build, vm_version.hpp includes vm_version_x86.hpp, which is over 1000 lines due to the complexity of the Intel architecture.

      vm_version.hpp is unnecessarily included by these popular header files:
         assembler.hpp
         assembler_x86.hpp
         threadLocalAllocBuffer.hpp

      There are 822 .o files that include vm_version.hpp. Refactoring the code reduces the number to 220 .o files.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. JDK-8259957 Build failure without C1 Compiler after JDK-8258004

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Enhancement - null JDK-8202579 Revisit VM_Version and VM_Version_ext for overlap and consolidation

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JDK-8259978 PPC64 builds broken after JDK-8258004

          • P2 - Crashes, loss of data, severe memory leak.
          • Resolved
          links to

          Commit Commit openjdk/jdk/492bebc7

          Review Review openjdk/jdk/2105

          Activity

            People

              iklam Ioi Lam
              iklam Ioi Lam
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: