Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8259623

JfrTypeSet::_subsystem_callback is left dangling after use

    XMLWordPrintable

Details

    • Enhancement
    • Resolution: Fixed
    • P4
    • 17
    • 11, 16, 17
    • hotspot
    • jfr
    • b16

    Description

      SonarCloud instance reports the bug in cases like:
        "Address of stack memory associated with local variable 'callback' is still referred to by the global variable '_subsystem_callback' upon returning to the caller. This will be a dangling reference"

      static void clear_packages() {
        ClearArtifact<PkgPtr> clear;
        ClearPackageCallback callback(&clear);
        _subsystem_callback = &callback;
        do_packages();
      }

      I understand that _subsystem_callback is assigned to be used in do_packages(), but it would indeed be left dangling. Maybe we should be doing something like CallbackInstallMark that would set _subsystem_callback back to NULL after we are done? Or, make Callbacks (i.e. ClearPackageCallback) self-installable, so they would both set themselves to _subsystem_callback and remove themselves?

      Attachments

        Issue Links

          Activity

            People

              shade Aleksey Shipilev
              shade Aleksey Shipilev
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: