-
Bug
-
Resolution: Fixed
-
P2
-
16
Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build |
---|---|---|---|---|---|---|
JDK-8260011 | 17 | Martin Buchholz | P2 | Resolved | Fixed | b06 |
JDK-8260151 | 16.0.1 | Martin Buchholz | P2 | Resolved | Fixed | b03 |
JDK-8310937 | 11.0.21 | Goetz Lindenmaier | P2 | Resolved | Fixed | b01 |
When the test for that fix is modified to add timed get, we again see intermittent failure.
Here's a version of SwallowedInterruptedException that has also been tweaked for jsr166 coding style.
java.lang.AssertionError: Test failed with [timed=true, iteration=65]
Caused by: java.lang.AssertionError: Future.get completed with interrupt status not set
/*
* Copyright (c) 2020, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.CountDownLatch;
import java.util.concurrent.ThreadLocalRandom;
import static java.util.concurrent.TimeUnit.DAYS;
import java.util.concurrent.atomic.AtomicReference;
/*
* @test
* @bug 8254350
* @run main SwallowedInterruptedException
* @key randomness
*/
// TODO: incorporate into CompletableFuture tck tests
public class SwallowedInterruptedException {
static final int ITERATIONS = 100;
public static void main(String[] args) throws Throwable {
ThreadLocalRandom rnd = ThreadLocalRandom.current();
for (int i = 1; i <= ITERATIONS; i++) {
boolean timed = rnd.nextBoolean();
CompletableFuture<Void> future = new CompletableFuture<>();
CountDownLatch threadRunning = new CountDownLatch(1);
AtomicReference<Throwable> fail = new AtomicReference<>();
Thread thread = new Thread(() -> {
threadRunning.countDown();
try {
Void result = (timed) ? future.get(1, DAYS) : future.get();
if (!Thread.currentThread().isInterrupted()) {
fail.set(new AssertionError(
"Future.get completed with interrupt status not set"));
}
} catch (InterruptedException ex) {
if (Thread.currentThread().isInterrupted()) {
fail.set(new AssertionError(
"InterruptedException with interrupt status set"));
}
} catch (Throwable ex) {
fail.set(ex);
}
});
thread.start();
threadRunning.await();
// interrupt thread, then set result after an optional (random) delay
thread.interrupt();
long sleepMillis = rnd.nextLong(10);
if (sleepMillis > 0)
Thread.sleep(sleepMillis);
future.complete(null);
thread.join();
if (fail.get() != null) {
throw new AssertionError(
String.format("Test failed with [timed=%s, iteration=%d]",
timed, i),
fail.get());
}
}
}
}
- backported by
-
JDK-8260011 timed CompletableFuture.get may swallow InterruptedException
- Resolved
-
JDK-8260151 timed CompletableFuture.get may swallow InterruptedException
- Resolved
-
JDK-8310937 timed CompletableFuture.get may swallow InterruptedException
- Resolved
- relates to
-
JDK-8254350 CompletableFuture.get may swallow InterruptedException
- Closed
- links to
-
Commit openjdk/jdk11u-dev/193dc76c
-
Commit openjdk/jdk16/f7b96d34
-
Review openjdk/jdk11u-dev/1961
-
Review openjdk/jdk11u-dev/1966
-
Review openjdk/jdk16/126