Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8260555

Change the default TIMEOUT_FACTOR from 4 to 1

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Fixed
    • Icon: P4 P4
    • 26
    • None
    • hotspot
    • b14

      Today the default TIMEOUT_FACTOR passed to jtreg is 4. Consider changing it to 1, to make it's usage a bit more easy to understand. (Note that this property accepts a float, so one can set TIMEOUT_FACTOR=0.25, if needed)

      This will require adaptation of the different code that use this property.

      The ones I know of:
      1) It's usage as a timeout for a test run. This default value will have to be bumped by x4.

      2) It's usage to scale IO waits - It's not apparent to me that the existing usages actually expect the x4. If we want to retain it, we could probably scale the few existing usages.

      3) It's usage to scale vmTestbase -stressTime. Need to change the default value, and update the tests that sets this explicitly. (Note, I'm not convinced that this scaling is good, but it's what our current tests do)

      [This JBS entry comes after a lengthy discussion between me and Igor about TIMEOUT_FACTOR and how it's used]

            lkorinth Leo Korinth
            stefank Stefan Karlsson
            Votes:
            0 Vote for this issue
            Watchers:
            12 Start watching this issue

              Created:
              Updated:
              Resolved: