-
Bug
-
Resolution: Fixed
-
P2
-
11, 16.0.1
-
b06
Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build |
---|---|---|---|---|---|---|
JDK-8262240 | 16.0.2 | Aleksey Shipilev | P2 | Resolved | Fixed | b01 |
JDK-8262974 | 15.0.3 | Aleksey Shipilev | P2 | Resolved | Fixed | b01 |
JDK-8261773 | 11.0.11 | Aleksey Shipilev | P2 | Resolved | Fixed | b03 |
/home/shade/trunks/jdk16/src/hotspot/share/utilities/vmError.cpp: In static member function 'static void VMError::controlled_crash(int)':
/home/shade/trunks/jdk16/src/hotspot/share/utilities/vmError.cpp:1799:29: error: aggregate 'VMError::controlled_crash(int)::FunctionDescriptor functionDescriptor' has incomplete type and cannot be defined
1799 | struct FunctionDescriptor functionDescriptor;
| ^~~~~~~~~~~~~~~~~~
`FunctionDescriptor` is from `src/hotspot/cpu/ppc/assembler_ppc.hpp`, and obviously not available for Zero.
The affected code was removed by
While not exactly the regression for 16, it would be nice to have this fixed for 16 and lower, to get clean builds on all platform configurations, including JDK 16 GA.
The fix is trivial:
diff --git a/src/hotspot/share/utilities/vmError.cpp b/src/hotspot/share/utilities/vmError.cpp
index 9b0dc413bcd..476fdc48e43 100644
--- a/src/hotspot/share/utilities/vmError.cpp
+++ b/src/hotspot/share/utilities/vmError.cpp
@@ -1795,7 +1795,7 @@ void VMError::controlled_crash(int how) {
char * const dataPtr = NULL; // bad data pointer
const void (*funcPtr)(void); // bad function pointer
-#if defined(PPC64) && !defined(ABI_ELFv2)
+#if defined(PPC64) && !defined(ABI_ELFv2) && !defined(ZERO)
struct FunctionDescriptor functionDescriptor;
functionDescriptor.set_entry((address) 0xF);
- backported by
-
JDK-8261773 PPC64 Zero build fails with 'VMError::controlled_crash(int)::FunctionDescriptor functionDescriptor' has incomplete type and cannot be defined
- Resolved
-
JDK-8262240 PPC64 Zero build fails with 'VMError::controlled_crash(int)::FunctionDescriptor functionDescriptor' has incomplete type and cannot be defined
- Resolved
-
JDK-8262974 PPC64 Zero build fails with 'VMError::controlled_crash(int)::FunctionDescriptor functionDescriptor' has incomplete type and cannot be defined
- Resolved
- relates to
-
JDK-8221175 Fix bad function case for controlled JVM crash on PPC64 big-endian
- Resolved
-
JDK-8252148 vmError::controlled_crash should be #ifdef ASSERT and move tests to gtest
- Resolved