-
Enhancement
-
Resolution: Fixed
-
P5
-
None
-
b10
-
x86
-
os_x
Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build |
---|---|---|---|---|---|---|
JDK-8268239 | 11.0.13 | Vladimir Kempik | P5 | Resolved | Fixed | b01 |
This was discovered during review of jep-391
os_bsd_x86.cpp has comment:
/*
NOTE: does not seem to work on bsd.
if (info == NULL || info->si_code <= 0 || info->si_code == SI_NOINFO) {
// can't decode this kind of signal
info = NULL;
} else {
assert(sig == info->si_signo, "bad siginfo");
}
*/
it was suggested it's better to remove it (in both bsd_x86 and future bsd_aarch64)
also that file includes pthread.h twice
os_bsd_x86.cpp has comment:
/*
NOTE: does not seem to work on bsd.
if (info == NULL || info->si_code <= 0 || info->si_code == SI_NOINFO) {
// can't decode this kind of signal
info = NULL;
} else {
assert(sig == info->si_signo, "bad siginfo");
}
*/
it was suggested it's better to remove it (in both bsd_x86 and future bsd_aarch64)
also that file includes pthread.h twice
- backported by
-
JDK-8268239 Remove some dead comments from os_bsd_x86
-
- Resolved
-