Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8261791

(sctp) handleSendFailed in SctpChannelImpl.c potential leaks

XMLWordPrintable

    • b11
    • generic
    • generic

        In another bug we had this question from me, and comment from Alan Bateman :

        Btw. while adjusting Java_sun_nio_ch_sctp_SctpChannelImpl_receive0 , I started to wonder what happens to the allocated memory in the same file in handleSendFailed ( if ((addressP = malloc(dataLength)) == NULL) ) in early return cases incl. the CHECK_NULL , is there some deallocation missing there too ?
        -----------------------------
        Yes, the error paths in handleSendFailed should be looked at. If NewDirectByteBuffer or recvmsg fails then addressP needs to be freed. Furthermore, if the NewObject fails and bufferObj != NULL then the memory for the direct buffer will need to be freed too (as JNI NewDirectByteBuffer does not setup a cleaner).
        --------------------------------
        So the coding should be adjusted to remove potential leaks.

              mbaesken Matthias Baesken
              mbaesken Matthias Baesken
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: