Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8261912

Code IfNode::fold_compares_helper more defensively

    XMLWordPrintable

Details

    • b64
    • 9
    • b11
    • Verified

    Backports

      Description

        As JDK-8261914 indicates, there are cases that break the internal asserts in IfNode::fold_compares_helper, code added by JDK-8073480 in JDK 9. Unfortunately, release builds would happily miscompile when that happens. It would be better to code IfNode::fold_compares_helper more defensively, so it bails when asserts are violated. This implicitly works around the bug in JDK-8261914. The goal for this limited workaround is to be trivially backportable in order to quickly unbreak 11u, 16u and 17.

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8262727 Code IfNode::fold_compares_helper more defensively

            • P2 - Crashes, loss of data, severe memory leak.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8263076 Code IfNode::fold_compares_helper more defensively

            • P2 - Crashes, loss of data, severe memory leak.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8263290 Code IfNode::fold_compares_helper more defensively

            • P2 - Crashes, loss of data, severe memory leak.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8262455 Code IfNode::fold_compares_helper more defensively

            • P2 - Crashes, loss of data, severe memory leak.
            • Closed

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8262962 Code IfNode::fold_compares_helper more defensively

            • P2 - Crashes, loss of data, severe memory leak.
            • Closed
            relates to

            Bug - A problem which impairs or prevents the functions of the product. JDK-8261914 IfNode::fold_compares_helper faces non-canonicalized bool when running JRuby JSON workload

            • P2 - Crashes, loss of data, severe memory leak.
            • Closed

            Enhancement - null JDK-8073480 C2 should optimize explicit range checks

            • P3 - Major loss of function.
            • Resolved
            links to

            Commit Commit openjdk/jdk16u/6be71baf

            Commit Commit openjdk/jdk/e9f3aab7

            Review Review openjdk/jdk16u/48

            Review Review openjdk/jdk/2610

            Activity

              People

                shade Aleksey Shipilev
                shade Aleksey Shipilev
                Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: