Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8263496

MetalHighContrastTheme.getControlHighlight cleanup

    XMLWordPrintable

Details

    • Enhancement
    • Status: Resolved
    • P4
    • Resolution: Fixed
    • 17
    • 17
    • client-libs

    Description

      SonarCloud reports the potential issue with MetalHighContrastTheme.getControlHighlight:
      Refactor this getter so that it actually refers to the field "controlHighlight".

         public ColorUIResource getControlHighlight() {
              // This was super.getSecondary3();
              return secondary2;
          }

      Indeed, there is a field:

          private static final ColorUIResource controlHighlight = new
                                    ColorUIResource(102, 102, 102);

      ...that is not used. Either we should use it, or remove the field declaration?

      Attachments

        Issue Links

          Activity

            People

              psadhukhan Prasanta Sadhukhan
              shade Aleksey Shipilev
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: