Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8264569

Remove obsolete error messages from CDSTestUtils.java

    XMLWordPrintable

Details

    • b19

    Description

      CDSTestUtils.java contains many messages that no longer exist in the HotSpot source code. We should remove tests for these error messages, and add new messages such as "Failed to reserve spaces" (see metaspaceShared.cpp).

      https://github.com/openjdk/jdk/blob/master/test/lib/jdk/test/lib/cds/CDSTestUtils.java#L356

      for i in \
      "Unable to reserve shared space at required address" \
      "Unable to map ReadOnly shared space at required address" \
      "Unable to map ReadWrite shared space at required address" \
      "Unable to map MiscData shared space at required address" \
      "Unable to map MiscCode shared space at required address" \
      "Unable to map OptionalData shared space at required address" \
      "Could not allocate metaspace at a compatible address" \
      "UseSharedSpaces: Unable to allocate region, range is not within java heap" \
      "DynamicDumpSharedSpaces is unsupported when base CDS archive is not loaded"; do
          XX=$(find . -name '*.?pp' -print | xargs grep "$i")
          if test "$XX" = ""; then
              echo OBSOLETE: $i
          fi
      done

      OBSOLETE: Unable to reserve shared space at required address
      OBSOLETE: Unable to map ReadOnly shared space at required address
      OBSOLETE: Unable to map ReadWrite shared space at required address
      OBSOLETE: Unable to map MiscData shared space at required address
      OBSOLETE: Unable to map MiscCode shared space at required address
      OBSOLETE: Unable to map OptionalData shared space at required address
      OBSOLETE: Could not allocate metaspace at a compatible address


      Attachments

        Issue Links

          Activity

            People

              minqi Yumin Qi
              iklam Ioi Lam
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: