Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8266670

Better modeling of access flags in core reflection

    XMLWordPrintable

Details

    • Enhancement
    • Status: Resolved
    • P4
    • Resolution: Fixed
    • 17
    • 20
    • core-libs
    • None

    Description

      Modifiers in core reflection and currently modeling using bit positions in an integer by java.lang.reflect.Modifier. This simple model does not fully capture existing nuances of modifiers. For example, there are collisions between the modifier bit positions for concepts used for fields, method, and types. These uses need to be disambiguated in for textual representations (JDK-6354476) and elsewhere.

      With the possibility of a bit position being reused in the same kind of construct for different purposes on different class file versions (JDK-8266524), a more capable model of core reflection modifiers will be needed.

      As a straw man proposal:
      - core reflection classes get a new "modifiers" method which returns an enum set of modifiers
      - the modifiers enum has a constant for each modifier. A modifier can include information such as its bit position, what kinds of constructs it is applicable to (classes, fields, methods, etc.), string representation, etc.

      This would allow bit positions with collisions, such as var-args and transient, to be modeled appropriately.

      Such a class would be analogous to javax.lang.model.element.Modifier.

      Attachments

        Issue Links

          csr for

          CSR - null JDK-8281660 Better modeling of access flags in core reflection

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. JDK-8289106 Add model of class file versions to core reflection

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Enhancement - null JDK-8286101 Support formatting in @value tag

          • P3 - Major loss of function.
          • Resolved

          Enhancement - null JDK-8291360 Create entry points to expose low-level class file information

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Enhancement - null JDK-8291734 Return accurate ACC_SUPER access flag for classes

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Enhancement - null JDK-8292576 Improve wording of AccessFlag-related specs

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Enhancement - null JDK-8281766 Update java.lang.reflect.Parameter to implement Member

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. JDK-6354476 (reflect) {Method, Constructor}.toString prints out inappropriate modifiers

          • P3 - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JDK-8297271 AccessFlags should be specific to class file version

          • P3 - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JDK-8296950 [lworld] AccessFlags should be specific to class file version

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Enhancement - null JDK-8145048 consider enhancements to EnumMap and EnumSet

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Enhancement - null JDK-8287330 (valhalla) Better modeling of access flags in core reflection

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          CSR - null JDK-8266524 javac changes for JEP 306

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          links to

          Commit Commit openjdk/jdk/de746714

          Review Review openjdk/jdk/7445

          Activity

            People

              darcy Joe Darcy
              darcy Joe Darcy
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: