P4
This is about tools/jpackage/junit/junit.java, which fails on jtreg 6, which provides updated versions of TestNG (7.3.0) and JUnit (4.13.2).
The problem is that this test is an "off-brand" use of JUnit in jtreg. The underlying root case is that JUnit has a new dependency on `hamcrest.jar`, which is provided in jtreg6, and available to "normal" JUnit tests. The immediate fix for this test appears to be to add it to this line:
* @library ${jtreg.home}/lib/hamcrest.jar
to open/test/jdk/tools/jpackage/junit/junit.java
https://github.com/jonathan-gibbons/jdk/blob/jtreg6/test/jdk/tools/jpackage/junit/junit.java#L29
However, in looking at this test we noticed a number of oddities.
The file `junit.java` just contains `@run shell run_junit.sh` so it is not clear why the test description is not in that `run_junit.sh` file (and remove junit.java).
The file `junit.java` has the wrong license (GPL2 + Classpath Exception). It should be plain GPL for any/all test files. This applies to most of the files in this directory.
The file `run_junit.sh` file does not have any legal header.
The problem is that this test is an "off-brand" use of JUnit in jtreg. The underlying root case is that JUnit has a new dependency on `hamcrest.jar`, which is provided in jtreg6, and available to "normal" JUnit tests. The immediate fix for this test appears to be to add it to this line:
* @library ${jtreg.home}/lib/hamcrest.jar
to open/test/jdk/tools/jpackage/junit/junit.java
https://github.com/jonathan-gibbons/jdk/blob/jtreg6/test/jdk/tools/jpackage/junit/junit.java#L29
However, in looking at this test we noticed a number of oddities.
The file `junit.java` just contains `@run shell run_junit.sh` so it is not clear why the test description is not in that `run_junit.sh` file (and remove junit.java).
The file `junit.java` has the wrong license (GPL2 + Classpath Exception). It should be plain GPL for any/all test files. This applies to most of the files in this directory.
The file `run_junit.sh` file does not have any legal header.
