Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8269661

JNI_GetStringCritical does not lock char array

    XMLWordPrintable

Details

    • gc
    • b30
    • Verified

    Backports

      Description

        The JNI_GetStringCritical method does not lock the char array in the !is_latin case, but returning it to the caller.

        I think the string object can actually be unlocked at end of the method in this case as it is never returned to the C code (just the char array, but this one is not locked at all).

        May cause crashes with gcs supporting object pinning (that is Shenandoah).

        Found after looking at the suggestion in JDK-8269650.

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8269973 JNI_GetStringCritical does not lock char array

            • P2 - Crashes, loss of data, severe memory leak.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8270713 JNI_GetStringCritical does not lock char array

            • P2 - Crashes, loss of data, severe memory leak.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8271298 JNI_GetStringCritical does not lock char array

            • P2 - Crashes, loss of data, severe memory leak.
            • Resolved
            relates to

            Bug - A problem which impairs or prevents the functions of the product. JDK-8269686 Shenandoah: Shenandoah needs to pin all object elements in an array

            • P2 - Crashes, loss of data, severe memory leak.
            • Resolved

            Bug - A problem which impairs or prevents the functions of the product. JDK-8269697 JNI_GetPrimitiveArrayCritical() should not accept object array

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Enhancement - null JDK-8269650 Optimize gc-locker in [Get|Release]StringCritical for latin string

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Enhancement - null JDK-8270110 Shenandoah: Add test for JDK-8269661

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            links to

            Commit Commit openjdk/jdk11u-dev/2a3d9080

            Commit Commit openjdk/jdk17/0f4e07b7

            Review Review openjdk/jdk11u-dev/109

            Review Review openjdk/jdk17/209

            Activity

              People

                kbarrett Kim Barrett
                tschatzl Thomas Schatzl
                Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: