Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8271215

Fix data races in G1PeriodicGCTask

    XMLWordPrintable

Details

    • gc
    • b08

    Backports

      Description

        G1PeriodicGCTask::should_start_periodic_gc calls g1h->time_since_last_collection(), possibly concurrently with the GC setting the collection time, leading to potential value tearing on 32bit platforms. There might be other similar problems; that's just the first one I noticed.

        should_start_periodic_gc should probably put it's entire body within an STS-joiner. This would be consistent with other G1ServiceTasks that use an STS-joiner to protect against GC concurrency.

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8275877 Fix data races in G1PeriodicGCTask

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            relates to

            Enhancement - null JDK-8271217 Fix race between G1PeriodicGCTask checks and GC request

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            links to

            Commit Commit openjdk/jdk17u/e85351d1

            Commit Commit openjdk/jdk/f2c359a8

            Review Review openjdk/jdk17u/51

            Review Review openjdk/jdk/4899

            Activity

              People

                kbarrett Kim Barrett
                kbarrett Kim Barrett
                Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: