Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8272118

ListViewSkin et al: must not cancel edit on scrolling

    XMLWordPrintable

Details

    Description

      this is basically reverting JDK-8114594 which cancels the edit on mouse interaction with the scrollBars. That bug is pre-historic (fixed in 2011, version fx2.0, before first commit accessible in the repository), has no description nor any tests.

      As noted in a comment to that issue, it's inconsistent/incomplete, behavior depends on how scrolling is done:

      - mousePressed on scrollBar: edit cancelled
      - by mousewheel/touchPad: does nothing
      - programmatically by control.scrollTo or scrollBar.setValue: does nothing

      My guess is that due to incomplete/missing update of editing state on cell re-use, edits were committed on incorrect items, leading to data corruption. After fixing these re-use issues (see JDK-8264127 and related), the brute-force cancel should no longer be needed.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. JDK-8150525 TableView: data corruption when editing newly added item

          • P3 - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JDK-8114436 Cell and editing: problems when scrolling

          • P3 - Major loss of function.
          • Closed

          Task - A task that needs to be done. JDK-8278134 Move static utility methods to infrastructure (EditAndScrollTest)

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JDK-8171847 More than one table cell are in edit state

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. JDK-8264127 ListCell editing status is true, when index changes while editing

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JDK-8114594 Cancel editing on scroll of List/tree/table

          • P3 - Major loss of function.
          • Closed
          links to

          Commit Commit openjdk/jfx/aa045c5e

          Review Review openjdk/jfx/682

          Activity

            People

              fastegal Jeanette Winzenburg
              fastegal Jeanette Winzenburg
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: