Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8272541

Incorrect overflow test in Toom-Cook branch of BigInteger multiplication

    XMLWordPrintable

Details

    • b13
    • generic
    • generic
    • Verified

    Backports

      Description

        In this code

        if (bitLength(mag, mag.length) +
           bitLength(val.mag, val.mag.length) >
           32L*MAX_MAG_LENGTH) {
           reportOverflow();
        }

        In the above, bitLength() returns 'int', hence the left operand of the '>' comparison is 'int' too, but the right operand of the '>' comparison is 'long' with value == Integer.MAX_VALUE + 1 hence this condition is always false.

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8281737 Incorrect overflow test in Toom-Cook branch of BigInteger multiplication

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8281759 Incorrect overflow test in Toom-Cook branch of BigInteger multiplication

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8281760 Incorrect overflow test in Toom-Cook branch of BigInteger multiplication

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8282033 Incorrect overflow test in Toom-Cook branch of BigInteger multiplication

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            links to

            Commit Commit openjdk/jdk11u-dev/d6bf0d1e

            Commit Commit openjdk/jdk13u-dev/359504c4

            Commit Commit openjdk/jdk15u-dev/e305f506

            Commit Commit openjdk/jdk17u-dev/8207e69a

            Commit Commit openjdk/jdk/d1aeca11

            Web Link Initial report of issue on core-libs-dev

            Review Review openjdk/jdk11u-dev/822

            Review Review openjdk/jdk13u-dev/327

            Review Review openjdk/jdk15u-dev/177

            Review Review openjdk/jdk17u-dev/154

            Review Review openjdk/jdk/5130

            Activity

              People

                bpb Brian Burkhalter
                bpb Brian Burkhalter
                Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: