-
Enhancement
-
Resolution: Fixed
-
P4
-
11, 17, 18
-
b12
Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build |
---|---|---|---|---|---|---|
JDK-8274010 | 17.0.2 | Aleksey Shipilev | P4 | Resolved | Fixed | b01 |
JDK-8274041 | 11.0.14 | Aleksey Shipilev | P4 | Resolved | Fixed | b01 |
The descriptions for Zap* options include the values that are used for zapping. Since these are not mechanically substituted from globalDefinitions.hpp, they can get desynced with the actual values used. For example, JDK-8184762 changed the pattern for ZapStackSegments, but never updated the option.
We should either drop the values from the options descriptions, or sync them with the definitions. Since we cannot mechanically check that zapping code actually uses the correct value, it seems simpler to just drop the zapping values from the descriptions.
The developers can always look into the globalDefinitions to find the exact value used on the particular zapping path:
https://github.com/openjdk/jdk/blob/594e5161b48382d61509b4969bc8f52c3c076452/src/hotspot/share/utilities/globalDefinitions.hpp#L961-L974
We should either drop the values from the options descriptions, or sync them with the definitions. Since we cannot mechanically check that zapping code actually uses the correct value, it seems simpler to just drop the zapping values from the descriptions.
The developers can always look into the globalDefinitions to find the exact value used on the particular zapping path:
https://github.com/openjdk/jdk/blob/594e5161b48382d61509b4969bc8f52c3c076452/src/hotspot/share/utilities/globalDefinitions.hpp#L961-L974
- backported by
-
JDK-8274010 Drop zapping values in the Zap* option descriptions
-
- Resolved
-
-
JDK-8274041 Drop zapping values in the Zap* option descriptions
-
- Resolved
-
- links to
-
Commit openjdk/jdk11u-dev/0d49433a
-
Commit openjdk/jdk17u/c2dc88fe
-
Commit openjdk/jdk/c5a27125
-
Review openjdk/jdk11u-dev/338
-
Review openjdk/jdk17u/63
-
Review openjdk/jdk/5223
(3 links to)