Cleanup unnecessary null comparison before instanceof check in java.naming

XMLWordPrintable

    • Type: Bug
    • Resolution: Fixed
    • Priority: P5
    • 18
    • Affects Version/s: 16, 17
    • Component/s: core-libs
    • None

      Update code checks both non-null and instance of a class in java.naming module classes.
      The checks and explicit casts could also be replaced with pattern matching for the instanceof operator.
      For example the following code:

              return (obj != null &&
                      obj instanceof CompoundName &&
                      impl.equals(((CompoundName)obj).impl));


      Can be simplified to:
          
              return (obj instanceof CompoundName other) &&
                      impl.equals(other.impl);

            Assignee:
            Andrey Turbanov
            Reporter:
            Andrey Turbanov
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: