Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8273486

Zero: Handle DiagnoseSyncOnValueBasedClasses VM option

    XMLWordPrintable

Details

    • b15

    Backports

      Description

        JDK-8257027 added a diagnostic option to check for synchronization on value-based classes. Zero does not support it, so it would fail the relevant test:

        $ CONF=linux-x86_64-zero-fastdebug make exploded-test TEST=runtime/Monitor/SyncOnValueBasedClassTest.java

        STDERR:
         stdout: [];
         stderr: [Exception in thread "main" java.lang.RuntimeException: synchronization on value based class did not fail
        at SyncOnValueBasedClassTest$FatalTest.main(SyncOnValueBasedClassTest.java:128)
        ]
         exitValue = 1

        java.lang.RuntimeException: 'fatal error: Synchronizing on object' missing from stdout/stderr

        Template interpreters implement this check by going to to slowpath that calls InterpreterRuntime::monitorenter. Zero already goes to that path when UseHeavyMonitors is enabled, so we might just enable it when lock diagnostics is requested. This would cost us zero (pun intended) when diagnostic option is disabled.

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8277199 Zero: Handle DiagnoseSyncOnValueBasedClasses VM option

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8277292 Zero: Handle DiagnoseSyncOnValueBasedClasses VM option

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            relates to

            Enhancement - null JDK-8273489 Zero: Handle UseHeavyMonitors on all monitorenter paths

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Bug - A problem which impairs or prevents the functions of the product. JDK-8288282 Zero-release build is broken after JDK-8279047 due to UseHeavyMonitors is read-only

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Enhancement - null JDK-8257027 [JEP 390] Diagnose synchronization on @ValueBased classes

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            links to

            Commit Commit openjdk/jdk17u/1d11bcd9

            Commit Commit openjdk/jdk/86a8e552

            Review Review openjdk/jdk17u/154

            Review Review openjdk/jdk17u/209

            Review Review openjdk/jdk/5412

            Activity

              People

                shade Aleksey Shipilev
                shade Aleksey Shipilev
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: