Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8273651

JFR: onMetadata(), setStartTime(), setEndTime() lacks test coverage

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Fixed
    • Icon: P3 P3
    • 18
    • 18
    • hotspot
    • jfr
    • b16

      The following three methods in RemoteRecordingStream class lacks test coverage:

      - onMetadata(MetadataEvent)
      - setStartTime(Instant)
      - setEndTime(Instant)

      The implementation of onMetadata, setStartTime, setEndTimedelegates to EventDirectoryStream used by EventStream::openRepository(). It should be sufficient to add sanity tests to open/test/jdk/jdk/jfr/jmx/streaming/TestDelegated.java

      The onMetadata fetches configurations, i.e default and profile, using a dedicated JMX call, so the test should check that they are included.

            egahlin Erik Gahlin
            egahlin Erik Gahlin
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: