Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8273806

compiler/cpuflags/TestSSE4Disabled.java should test for CPU feature explicitly

XMLWordPrintable

    • b16

        JDK-8158214 added a test that verifies that machines with SSE4 support do not crash when lower SSE level is required. But it tests for CPU capabilities weirdly.

        This _tangentially_ manifests when running the test with Zero:

        ```
        $ CONF=linux-x86_64-zero-fastdebug make exploded-test TEST=compiler/cpuflags/TestSSE4Disabled.java
        ...
        STDERR:
        Unrecognized VM option 'UseSSE=3'
        Error: Could not create the Java Virtual Machine.
        Error: A fatal exception has occurred. Program will exit.
        ```

        I think we can test that target CPU supports SSE4, and only run the test then. It would implicitly fix Zero test failure too, as Zero impersonates a "generic" featureless CPU. Plus, it would stop running the -Xcomp test on arches that do not actually need to run this test.

              shade Aleksey Shipilev
              shade Aleksey Shipilev
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Created:
                Updated:
                Resolved: