Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8273806

compiler/cpuflags/TestSSE4Disabled.java should test for CPU feature explicitly

    XMLWordPrintable

Details

    • b16

    Backports

      Description

        JDK-8158214 added a test that verifies that machines with SSE4 support do not crash when lower SSE level is required. But it tests for CPU capabilities weirdly.

        This _tangentially_ manifests when running the test with Zero:

        ```
        $ CONF=linux-x86_64-zero-fastdebug make exploded-test TEST=compiler/cpuflags/TestSSE4Disabled.java
        ...
        STDERR:
        Unrecognized VM option 'UseSSE=3'
        Error: Could not create the Java Virtual Machine.
        Error: A fatal exception has occurred. Program will exit.
        ```

        I think we can test that target CPU supports SSE4, and only run the test then. It would implicitly fix Zero test failure too, as Zero impersonates a "generic" featureless CPU. Plus, it would stop running the -Xcomp test on arches that do not actually need to run this test.

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8274708 compiler/cpuflags/TestSSE4Disabled.java should test for CPU feature explicitly

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8298001 compiler/cpuflags/TestSSE4Disabled.java should test for CPU feature explicitly

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8303195 compiler/cpuflags/TestSSE4Disabled.java should test for CPU feature explicitly

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            relates to

            Bug - A problem which impairs or prevents the functions of the product. JDK-8158214 Crash with "assert(VM_Version::supports_sse4_1()) failed" if UseSSE < 4 is set

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            links to

            Commit Commit openjdk/jdk11u-dev/b3820b21

            Commit Commit openjdk/jdk17u/e6675c78

            Commit Commit openjdk/jdk/09ecb119

            Review Review openjdk/jdk11u-dev/1767

            Review Review openjdk/jdk17u/131

            Review Review openjdk/jdk/5530

            Activity

              People

                shade Aleksey Shipilev
                shade Aleksey Shipilev
                Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: