Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8275687

runtime/CommandLine/PrintTouchedMethods test shouldn't catch RuntimeException

XMLWordPrintable

    • b26

        https://github.com/openjdk/jdk/pull/5231#pullrequestreview-784995993

        I think this is an existing bug. Do we need this catch block? TouchedMethodsDCmd is always enabled as long as the current JVM has INCLUDE_SERVICES is true. If INCLUDE_SERVICES is false, the jcmd connection will fail, and you will get a different error, like
        `com.sun.tools.attach.AttachNotSupportedException: Unable to open socket file /proc/18810/root/tmp/.java_pid18810: target process 18810 doesn't respond within 10500ms or HotSpot VM not loaded`

        The catch block will incorrectly ignore the problem if the VM is incorrectly modified and the TouchedMethodsDCmd is inadvently excluded.

              fmatte Fairoz Matte
              iignatyev Igor Ignatyev (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated:
                Resolved: