Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8275687

runtime/CommandLine/PrintTouchedMethods test shouldn't catch RuntimeException

    XMLWordPrintable

Details

    • b26

    Backports

      Description

        https://github.com/openjdk/jdk/pull/5231#pullrequestreview-784995993

        I think this is an existing bug. Do we need this catch block? TouchedMethodsDCmd is always enabled as long as the current JVM has INCLUDE_SERVICES is true. If INCLUDE_SERVICES is false, the jcmd connection will fail, and you will get a different error, like
        `com.sun.tools.attach.AttachNotSupportedException: Unable to open socket file /proc/18810/root/tmp/.java_pid18810: target process 18810 doesn't respond within 10500ms or HotSpot VM not loaded`

        The catch block will incorrectly ignore the problem if the VM is incorrectly modified and the TouchedMethodsDCmd is inadvently excluded.

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8280156 runtime/CommandLine/PrintTouchedMethods test shouldn't catch RuntimeException

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8280570 runtime/CommandLine/PrintTouchedMethods test shouldn't catch RuntimeException

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            links to

            Commit Commit openjdk/jdk17u-dev/6315ce3c

            Commit Commit openjdk/jdk/f0136ec9

            Review Review openjdk/jdk17u-dev/115

            Review Review openjdk/jdk/6536

            Activity

              People

                fmatte Fairoz Matte
                iignatyev Igor Ignatyev (Inactive)
                Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: