Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8275704

Metaspace::contains() should be threadsafe

    XMLWordPrintable

Details

    • b22

    Backports

      Description

        Metaspace::contains() is used in many places. It is not threadsafe since it walks the list of metaspace mappings, which can be altered concurrently. This is suspected to be the cause for JDK-8271124.

        This is a day zero bug of metaspace, in there since JDK 8. Weirdly enough it never surfaced until now.

        Currently, it does not lock, and adding a lock is not realistic either. It should work lockless. (See discussion in comment section of JDK-8271124).

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8301323 Metaspace::contains() should be threadsafe

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            duplicates

            Bug - A problem which impairs or prevents the functions of the product. JDK-8271124 CTW tests crashed with assert(is_valid_method(o)) failed: should be valid jmethodid

            • P3 - Major loss of function.
            • Closed
            is blocked by

            Bug - A problem which impairs or prevents the functions of the product. JDK-8275582 Don't purge metaspace mapping lists

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            relates to

            Bug - A problem which impairs or prevents the functions of the product. JDK-8276086 Increase size of metaspace mappings

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Bug - A problem which impairs or prevents the functions of the product. JDK-8271124 CTW tests crashed with assert(is_valid_method(o)) failed: should be valid jmethodid

            • P3 - Major loss of function.
            • Closed
            links to

            Commit Commit openjdk/jdk17u-dev/4a9bd23a

            Commit Commit openjdk/jdk/d9b0138d

            Review Review openjdk/jdk17u-dev/1120

            Review Review openjdk/jdk/6060

            Activity

              People

                stuefe Thomas Stuefe
                stuefe Thomas Stuefe
                Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: