[JDK-8275771] JDK source code contains redundant boolean operations in jdk.compiler and langtools - Java Bug System

XML

Word

Printable

Details

Type: Bug
Status: Resolved
Priority: P4
Resolution: Fixed
Affects Version/s: 18
Fix Version/s: 18
Component/s: tools
Labels:
- 18ea
- dcsaw
- noreg-cleanup
- reproducer-other
- webbug

Subcomponent:
javac
Resolved In Build:
b27
CPU:

generic
OS:

generic

Backports

Issue	Fix Version	Assignee	Priority	Status	Resolution	Resolved In Build
JDK-8278697	19	Vicente Arturo Romero Zaldivar	P4	Resolved	Fixed	team

Description

A DESCRIPTION OF THE PROBLEM :
The JDK source code contains the following redundant boolean operations which have no effect; some of them could be simplified and some might be bugs.

- https://github.com/openjdk/jdk/blob/7fc3a8d052bfb8d31fedec56f72b10a40ba7bf83/make/langtools/tools/compileproperties/CompileProperties.java#L186
`true &&` has no effect; maybe wrong precedence?

- Should simplify to `= false`
  https://github.com/openjdk/jdk/blob/7fc3a8d052bfb8d31fedec56f72b10a40ba7bf83/src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java#L1304
  https://github.com/openjdk/jdk/blob/7fc3a8d052bfb8d31fedec56f72b10a40ba7bf83/src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java#L1318
  https://github.com/openjdk/jdk/blob/7fc3a8d052bfb8d31fedec56f72b10a40ba7bf83/src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java#L1340
- Has no effect, should maybe be `= true`?
  https://github.com/openjdk/jdk/blob/7fc3a8d052bfb8d31fedec56f72b10a40ba7bf83/src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java#L1316
  https://github.com/openjdk/jdk/blob/7fc3a8d052bfb8d31fedec56f72b10a40ba7bf83/src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java#L1338

Attachments

Issue Links

backported by

JDK-8278697 JDK source code contains redundant boolean operations in jdk.compiler and langtools

Resolved

clones

JDK-8275767 JDK source code contains redundant boolean operations in jdk.charsets

Resolved

links to

Commit openjdk/jdk/3c2951f7

Review openjdk/jdk/6599

Activity

People

Assignee:: Vicente Arturo Romero Zaldivar

Reporter:: Andrew Wang

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 2021-10-21 23:26

Updated:: 2021-12-13 19:20

Resolved:: 2021-12-07 15:32