Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8276205

Shenandoah: CodeCache_lock should always be held for initializing code cache iteration

    XMLWordPrintable

Details

    • gc
    • b22

    Backports

      Description

        Before concurrent GC, CodeCache_lock is not required for walking CodeCache at safepoints. But it is not the case for Shenandoah, as code cache iteration can be initialized and run through safepoints.

        To initialize concurrent code cache iteration, CodeCache_lock is required, even at safepoints, as the lock is acquired without safepoint check.

        There are few bugs in current implementation:
        1) No CodeCache_lock is held when initialize code cache iterator at safepoints.

        2) Does not notify waiters upon completion of iteration at safepoints

        3) Unnecessary held CodeCache_lock during concurrent code cache iteration.


        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8277339 Shenandoah: CodeCache_lock should always be held for initializing code cache iteration

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8277683 Shenandoah: CodeCache_lock should always be held for initializing code cache iteration

            • P3 - Major loss of function.
            • Resolved
            relates to

            Bug - A problem which impairs or prevents the functions of the product. JDK-8276801 gc/stress/CriticalNativeStress.java fails intermittently with Shenandoah

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            links to

            Commit Commit openjdk/jdk17u/f1a8a22f

            Commit Commit openjdk/jdk/99b7b95e

            Review Review openjdk/jdk17u/262

            Review Review openjdk/jdk/6192

            Activity

              People

                zgu Zhengyu Gu
                zgu Zhengyu Gu
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: