Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8277029

JMM GetDiagnosticXXXInfo APIs should verify output array sizes

    XMLWordPrintable

Details

    • svc
    • b24

    Backports

      Description

        jmm_GetDiagnosticCommandArgumentsInfo and jmm_GetDiagnosticCommandInfo are used to query the hotspot about diagnostic commands. They provide output arrays for the information:

        ```
        void jmm_GetDiagnosticCommandArgumentsInfo(JNIEnv *env,
                  jstring command, dcmdArgInfo* infoArray)
        ```

        but array size is implicitly assumed to be known to both caller and callee. Caller and callee negotiate those sizes in prior steps, but things can go wrong. E.g. I recently hunted a bug where `DCmd::number_arguments()` was off - did not reflect the real number of its jcmd parameters - which led to a hidden memory overwriter.

        Thankfully, JDK-8264565 rewrote the dcmd framework to deal with this particular issue (The VM I analyzed was older). Still, it would be good if we had additional safety measures here.

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8277476 JMM GetDiagnosticXXXInfo APIs should verify output array sizes

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8277482 JMM GetDiagnosticXXXInfo APIs should verify output array sizes

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8277692 JMM GetDiagnosticXXXInfo APIs should verify output array sizes

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8288366 JMM GetDiagnosticXXXInfo APIs should verify output array sizes

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            relates to

            Enhancement - null JDK-8264565 Templatize num_arguments() functions of DCmd subclasses

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            links to

            Commit Commit openjdk/jdk11u-dev/9b944096

            Commit Commit openjdk/jdk17u/0e896e7f

            Commit Commit openjdk/jdk/b8d33a2a

            Review Review openjdk/jdk11u-dev/635

            Review Review openjdk/jdk17u/276

            Review Review openjdk/jdk/6363

            Activity

              People

                stuefe Thomas Stuefe
                stuefe Thomas Stuefe
                Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: