Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8277076

ciReplay: better replay error messages

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Unresolved
    • Icon: P3 P3
    • tbd
    • 18
    • hotspot

      From 8276095 review:

           } else if (strcmp("version", cmd) == 0) {
            _version = parse_int("version");
            if (_version > REPLAY_VERSION) {
              report_error("unrecognized version");

      Vladimir:

      Would be nice to print both versions numbers in error message.
      Also I would like to be able ignore such error and process file anyway. Is report_error allows it?

      Dean:

      Currently report_error() saves the error string to be printed later, so to have an error message that requires formatting, I guess I would have to allocate the string using malloc or ResourceObj memory.
      Right now the only ignore flag is ReplayIgnoreInitErrors. I could introduce something like ReplayIgnoreAllErrors , or maybe turn this error into a warning.

            Unassigned Unassigned
            dlong Dean Long
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: