Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8278207

G1: Tighten verification in G1ResetSkipCompactingClosure

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Fixed
    • Icon: P4 P4
    • 19
    • 18
    • hotspot
    • gc
    • b05

      `G1FullGCPrepareTask::G1CalculatePointersClosure::do_heap_region` contains the following structure:

      ```
      if (is_humongous) {
      } else if (is_open_archive()) {
      } else if (is_closed_archive()) {
      } else {
      }
      ```

      The verification in `G1ResetSkipCompactingClosure` basically checks whether skip-compacting regions actually meet the criteria to skip compaction.

      To make the code more straightforward, it should mirror the original structure as well, instead of a single assert.

            ayang Albert Yang
            ayang Albert Yang
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: