Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8278389

SuspendibleThreadSet::_suspend_all should be volatile/atomic

    XMLWordPrintable

Details

    • gc
    • b29

    Backports

      Description

        SuspendibleThreadSet::should_yield() just returns the value of the _suspend_all flag, which is a simple static variable. That variable is set under a lock, but possibly read concurrently by other threads without any locking.

        [For considerations of backporting] This is *probably* effectively harmless, as any loops involving should_yield checks probably won't have the check hoisted out of the loop due to sufficiently opaque loop bodies.

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8278933 SuspendibleThreadSet::_suspend_all should be volatile/atomic

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8279726 SuspendibleThreadSet::_suspend_all should be volatile/atomic

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8280446 SuspendibleThreadSet::_suspend_all should be volatile/atomic

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8292050 SuspendibleThreadSet::_suspend_all should be volatile/atomic

            • P3 - Major loss of function.
            • Resolved
            relates to

            Bug - A problem which impairs or prevents the functions of the product. JDK-8278475 G1 dirty card refinement by Java threads may get unnecessarily paused

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            links to

            Commit Commit openjdk/jdk17u-dev/a39960a4

            Commit Commit openjdk/jdk18/aec1b039

            Review Review openjdk/jdk17u-dev/54

            Review Review openjdk/jdk18/9

            Review Review openjdk/jdk18/10

            Activity

              People

                tschatzl Thomas Schatzl
                kbarrett Kim Barrett
                Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: