Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8279225

[arm32] C1 longs comparison operation destroys argument registers

    XMLWordPrintable

Details

    • b04
    • arm
    • linux

    Backports

      Description

        Several regression tests are failed on arm32 CPU if tiered compilation is enabled.

        The list includes
        java/math/BigDecimal/DivideMcTests
        java/util/Arrays/Sorting.java
        java/util/Arrays/SortingNearlySortedPrimitive.java
        java/util/concurrent/tck/JSR166TestCase
        java/util/stream/SliceOpTest.java
        etc

        It appears C1 comp_op for long operands destroys arguments registers:
        void LIR_Assembler::comp_op(LIR_Condition condition, LIR_Opr opr1, LIR_Opr opr2, LIR_Op2* op) {
        ....
              Register ylo = opr2->as_register_lo();
              Register yhi = opr2->as_register_hi();
              if (condition == lir_cond_equal || condition == lir_cond_notEqual) {
                __ teq(xhi, yhi);
                __ teq(xlo, ylo, eq);
              } else {
                __ subs(xlo, xlo, ylo); // <<< incorrect
                __ sbcs(xhi, xhi, yhi); // <<< incorrect
              }
        ...
        }

        The bug persist at all version of JDK since ARM32 code was opensourced.

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8279440 [arm32] C1 longs comparison operation destroys argument registers

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8279507 [arm32] C1 longs comparison operation destroys argument registers

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8279679 [arm32] C1 longs comparison operation destroys argument registers

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8279681 [arm32] C1 longs comparison operation destroys argument registers

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8281188 [arm32] C1 longs comparison operation destroys argument registers

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8281989 [arm32] C1 longs comparison operation destroys argument registers

            • P3 - Major loss of function.
            • Resolved
            links to

            Commit Commit openjdk/jdk11u-dev/e1ee008c

            Commit Commit openjdk/jdk17u-dev/744d785d

            Commit Commit openjdk/jdk18u/313932af

            Commit Commit openjdk/jdk/299022df

            Review Review openjdk/jdk11u-dev/743

            Review Review openjdk/jdk17u-dev/62

            Review Review openjdk/jdk18u/15

            Review Review openjdk/jdk/6934

            Activity

              People

                snazarki Sergey Nazarkin
                snazarki Sergey Nazarkin
                Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: