Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8280932

G1: Rename HeapRegionRemSet::_code_roots accessors

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Fixed
    • Icon: P4 P4
    • 19
    • None
    • hotspot
    • gc
    • b08

      JDK-8035406 renamed `_strong_code_roots_list` -> `_code_roots` in `HeapRegionRemSet`, but its relevant accessors still keep the "strong" prefix, e.g. `add_strong_code_root`.

      Such inconsistency can cause some rather odd code, e.g. in `G1ScanCollectionSetRegionClosure`:

      ```
      r->strong_code_roots_do(_pss->closures()->weak_codeblobs());
      ```

      applying the weak closure on strong roots.

      Drop the "strong" prefix to reconcile the names of the field and its accessors .

            ayang Albert Yang
            ayang Albert Yang
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: