Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8281122

[IR Framework] Cleanup IR matching code in preparation for JDK-8280378

    XMLWordPrintable

Details

    • b13

    Backports

      Description

        The current implementation of the IRMatcher class makes it difficult to add IR matching on different compile phases (JDK-8280378). There is a lack of separation of concerns. Multiple things are tightly mixed together:
        - IR encoding parsing
        - hotspot_pid* file parsing
        - IR matching
        - IR annotation format checking
        - Failure reporting

        This RFE splits the single IRMatcher class into multiple classes to separate different phases (parsing, matching, reporting) and better structure the involved components (methods, rules, IR annotation attributes and its contraints etc.). This should make it easier to implement JDK-8280378 and possibly more IR matching features in the future.

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8296874 [IR Framework] Cleanup IR matching code in preparation for JDK-8280378

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8299461 [IR Framework] Cleanup IR matching code in preparation for JDK-8280378

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            relates to

            Enhancement - null JDK-8292190 [IR Framework] Remove redundant regex matching for failing counts constraints

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Enhancement - null JDK-8280378 [IR Framework] Support IR matching for different compile phases

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            links to

            Commit Commit openjdk/jdk17u-dev/475ca049

            Commit Commit openjdk/jdk/2da67779

            Review Review openjdk/jdk17u-dev/995

            Review Review openjdk/jdk/7533

            Activity

              People

                chagedorn Christian Hagedorn
                chagedorn Christian Hagedorn
                Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: