-
Type:
Enhancement
-
Resolution: Fixed
-
Priority:
P4
-
Affects Version/s: 17
-
Component/s: tools
-
Environment:
JDK 17.0.2
Windows 11 (Version 10.0.22000.493)
-
b24
-
windows_10
| Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build |
|---|---|---|---|---|---|---|
| JDK-8370170 | 17.0.18 | Goetz Lindenmaier | P4 | Resolved | Fixed | b01 |
This is compounded by the fact that the same .ico file will be made into multiple copies when multiple launchers are used, even if they don't have unique icons.
For some applications the .ico file is the largest file outside of the Java runtime. There is no need to have multiple redundant copies of it.
I attempted to work around this by removing .ico files from the app-image after creating it, but this leads to failures when making an .msi file from the app-image. Shortcut elements in the intermediate bundle.wxf file refer to the .ico files, which is not useful since the same icon is in the .exe they are referring to and specifying a separate icon is optional. E.g. in:
<Shortcut Id="shortcut99d00e1ede14399d8ee8e9d74ba8b6f8" Name="MyLauncher" WorkingDirectory="INSTALLDIR" Advertise="no" IconIndex="0" Target="[#file64e3276016c53c7cb3719ad2f26bd4f3]" Icon="icon897347353"></Shortcut>
IconIndex and Icon attributes are not needed. See https://wixtoolset.org/documentation/manual/v3/howtos/files_and_registry/create_start_menu_shortcut.html
- backported by
-
JDK-8370170 Redundant .ico files in Windows app-image cause unnecessary bloat
-
- Resolved
-
- causes
-
JDK-8287401 jpackage tests failing on Windows due to powershell issue
-
- Resolved
-
-
JDK-8290557 tools/jpackage/share/AddLauncherTest.java#id1 failed with "ERROR: Failed: Check icon file"
-
- Resolved
-
-
JDK-8299278 tools/jpackage/share/AddLauncherTest.java#id1 failed AddLauncherTest.bug8230933
-
- Resolved
-
- links to
-
Commit
openjdk/jdk/45180633
-
Commit(master)
openjdk/jdk17u-dev/5d06ac0e
-
Review
openjdk/jdk/8794
-
Review(master)
openjdk/jdk17u-dev/4054