Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8282224

Correct TIG::bang_stack_shadow_pages comments

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Fixed
    • Icon: P4 P4
    • 19
    • 19
    • hotspot
    • b13

      When reviewing the RISC-V port of the change, I noticed the comment in the x86 code is worded incorrectly:

        // Record a new watermark, unless the update is above the safe limit.
        __ cmpptr(rsp, Address(thread, JavaThread::shadow_zone_safe_limit()));
        __ jccb(Assembler::belowEqual, L_done);

      Stacks grow downwards, so we are recording a new watermark *when* update is above the safe limit.

            shade Aleksey Shipilev
            shade Aleksey Shipilev
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: