Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8282665

[REDO] ByteBufferTest.java: replace endless recursion with RuntimeException in void ck(double x, double y)

    XMLWordPrintable

Details

    • b13

    Backports

      Description

        We have two functions ck, that are supposed to compare the two inputs and make the test fail if they are not equal.

            void ck(long x, long y) {
                if (x != y) {
                    throw new RuntimeException(" x = " + Long.toHexString(x) + ", y = " + Long.toHexString(y));
                }
            }

            void ck(double x, double y) {
                if (x == x && y == y && x != y) {
                    ck(x, y);
                }
            }

        The long throws a RuntimeException.
        The one for double goes into an infinite recursion, and eventually throws a StackOverflowError. This does not make much sense.
        I spoke with the original author [~psandoz], he agrees to replace it with an analogue RuntimeException.

            void ck(double x, double y) {
                if (x == x && y == y && x != y) {
                    throw new RuntimeException(...);
                }
            }

        Code introduced in JDK-8151163.
        Bug in JDK-8282555 encountered both this endless recursion as the RuntimeException, of the respective ck functions.

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8307324 [REDO] ByteBufferTest.java: replace endless recursion with RuntimeException in void ck(double x, double y)

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8310378 [REDO] ByteBufferTest.java: replace endless recursion with RuntimeException in void ck(double x, double y)

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8315211 [REDO] ByteBufferTest.java: replace endless recursion with RuntimeException in void ck(double x, double y)

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8321264 [REDO] ByteBufferTest.java: replace endless recursion with RuntimeException in void ck(double x, double y)

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            clones

            Enhancement - null JDK-8282573 ByteBufferTest.java: replace endless recursion with RuntimeException in void ck(double x, double y)

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Closed
            relates to

            Sub-task - The sub-task of the issue JDK-8282661 [BACKOUT] ByteBufferTest.java: replace endless recursion with RuntimeException in void ck(double x, double y)

            • P1 - Blocks development and/or testing work, production could not run.
            • Resolved

            Bug - A problem which impairs or prevents the functions of the product. JDK-8282555 Missing memory edge when spilling MoveF2I, MoveD2L etc

            • P2 - Crashes, loss of data, severe memory leak.
            • Closed

            Enhancement - null JDK-8151163 All Buffer implementations should leverage Unsafe unaligned accessors

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            links to

            Commit Commit openjdk/jdk11u-dev/d4fcded4

            Commit Commit openjdk/jdk17u-dev/bda6723c

            Commit Commit openjdk/jdk/a584c904

            Commit Commit openjdk/jdk/d07f7c76

            Review Review openjdk/jdk11u-dev/2309

            Review Review openjdk/jdk17u-dev/1470

            Review Review openjdk/jdk/7674

            Review Review openjdk/jdk/7723

            Activity

              People

                epeter Emanuel Peter
                epeter Emanuel Peter
                Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: