Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8282849

Loom: Fix minimal debug non-PCH build failure

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Won't Fix
    • Icon: P4 P4
    • repo-loom
    • repo-loom
    • hotspot
    • None

      This failure was exposed by the GHA in Loom repo. See https://github.com/shqking/loom/runs/5228845832?check_suite_focus=true

      Configure:

      bash configure --with-conf-name=linux--hotspot --enable-debug --disable-precompiled-headers --with-jvm-variants=minimal --with-version-opt=${GITHUB_ACTOR}-${GITHUB_SHA} --with-version-build=0 --with-boot-jdk=${HOME}/bootjdk/${BOOT_JDK_VERSION} --with-build-jdk=/home/runner/jdk-linux-x64/jdk-19-internal+0_linux-x64_bin/jdk-19 --with-default-make-target="hotspot" --with-zlib=system

      Here is the error message.

      === Output from failing command(s) repeated here ===
      * For target hotspot_variant-minimal_libjvm_objs_accessBarrierSupport.o:
      In file included from /home/runner/work/loom/loom/jdk/src/hotspot/share/gc/shared/accessBarrierSupport.cpp:26:
      /home/runner/work/loom/loom/jdk/src/hotspot/share/classfile/javaClasses.inline.hpp: In static member function 'static void jdk_internal_vm_StackChunk::set_maxSize(oop, jint)':
      /home/runner/work/loom/loom/jdk/src/hotspot/share/classfile/javaClasses.inline.hpp:338:21: error: 'jvmcont' was not declared in this scope; did you mean 'cont'?
        338 | log_develop_trace(jvmcont)("%s max_size: %d -> %d", value >= old ? "add" : "sub", old, value);
            | ^~~~~~~
            | cont
      /home/runner/work/loom/loom/jdk/src/hotspot/share/classfile/javaClasses.inline.hpp:338:3: error: 'log_develop_trace' was not declared in this scope
        338 | log_develop_trace(jvmcont)("%s max_size: %d -> %d", value >= old ? "add" : "sub", old, value);
            | ^~~~~~~~~~~~~~~~~

      * All command lines available in /home/runner/work/loom/loom/jdk/build/linux--hotspot/make-support/failure-logs.
      === End of repeated output ===

      I suppose this failure was introduced by commit bd25c94 (link: https://github.com/openjdk/loom/commit/bd25c94#diff-685be8f81952a04ccc9c265d5613b07d423e8cac5b5f5506b2a6a244c5a1ebf2R336-R339)


      If we remove the erroneous lines added in commit bd25c94, we would get another build failure. Here is the error message.

      === Output from failing command(s) repeated here ===
      * For target hotspot_variant-minimal_libjvm_objs_instanceStackChunkKlass.o:
      ~/loom/loom-src/src/hotspot/share/oops/instanceStackChunkKlass.cpp: In instantiation of 'bool VerifyStackClosure::do_frame(const StackChunkFrameStream<frames>&, const RegisterMapT*) [with chunk_frames frame_kind = MIXED; RegisterMapT = RegisterMap]':
      ~/loom/loom-src/src/hotspot/share/oops/instanceStackChunkKlass.inline.hpp:618:61: required from 'static void InstanceStackChunkKlass::iterate_stack(stackChunkOop, StackChunkFrameClosureType*) [with chunk_frames frames = MIXED; StackChunkFrameClosureType = VerifyStackClosure]'
      ~/loom/loom-src/src/hotspot/share/oops/stackChunkOop.inline.hpp:301:83: required from 'void stackChunkOopDesc::iterate_stack(StackChunkFrameClosureType*) [with StackChunkFrameClosureType = VerifyStackClosure]'
      ~/loom/loom-src/src/hotspot/share/oops/instanceStackChunkKlass.cpp:917:32: required from here
      ~/loom/loom-src/src/hotspot/share/oops/instanceStackChunkKlass.cpp:832:17: error: 'LogStream ls' has incomplete type
       832 | LogStream ls(lt);
       | ^~
      ~/loom/loom-src/src/hotspot/share/oops/instanceStackChunkKlass.cpp: In instantiation of 'bool VerifyStackClosure::do_frame(const StackChunkFrameStream<frames>&, const RegisterMapT*) [with chunk_frames frame_kind = MIXED; RegisterMapT = SmallRegisterMap]':
      ~/loom/loom-src/src/hotspot/share/oops/instanceStackChunkKlass.inline.hpp:628:61: required from 'static void InstanceStackChunkKlass::iterate_stack(stackChunkOop, StackChunkFrameClosureType*) [with chunk_frames frames = MIXED; StackChunkFrameClosureType = VerifyStackClosure]'
      ~/loom/loom-src/src/hotspot/share/oops/stackChunkOop.inline.hpp:301:83: required from 'void stackChunkOopDesc::iterate_stack(StackChunkFrameClosureType*) [with StackChunkFrameClosureType = VerifyStackClosure]'
      ~/loom/loom-src/src/hotspot/share/oops/instanceStackChunkKlass.cpp:917:32: required from here
      ~/loom/loom-src/src/hotspot/share/oops/instanceStackChunkKlass.cpp:832:17: error: 'LogStream ls' has incomplete type
      ~/loom/loom-src/src/hotspot/share/oops/instanceStackChunkKlass.cpp: In instantiation of 'bool VerifyStackClosure::do_frame(const StackChunkFrameStream<frames>&, const RegisterMapT*) [with chunk_frames frame_kind = COMPILED_ONLY; RegisterMapT = RegisterMap]':
      ~/loom/loom-src/src/hotspot/share/oops/instanceStackChunkKlass.inline.hpp:618:61: required from 'static void InstanceStackChunkKlass::iterate_stack(stackChunkOop, StackChunkFrameClosureType*) [with chunk_frames frames = COMPILED_ONLY; StackChunkFrameClosureType = VerifyStackClosure]'
      ~/loom/loom-src/src/hotspot/share/oops/stackChunkOop.inline.hpp:302:91: required from 'void stackChunkOopDesc::iterate_stack(StackChunkFrameClosureType*) [with StackChunkFrameClosureType = VerifyStackClosure]'
       ... (rest of output omitted)

      I suppose this failure was introduced in commit 4d27102 (Link: https://github.com/openjdk/loom/commit/4d27102f3b39#diff-b1c9b70c8d0bc94f4f42070a8110e43f99905b464b9fbf0953fc1237e273890eR830-R834)

            haosun Hao Sun
            haosun Hao Sun
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: