[~dholmes] requested a comment be added after the fix for:

    JDK-8284632 runtime/Thread/StopAtExit.java possibly leaking memory again

was integrated.

src/hotspot/share/runtime/thread.cpp:

1673: ~InstallAsyncExceptionHandshake() {
1674: delete _aeh;

Member
@dholmes-ora dholmes-ora 20 hours ago

A comment would have been good. I'm assuming:

// Can only be non-null if this handshake was never actually executed.
Member Author
@dcubed-ojdk dcubed-ojdk 20 hours ago

Since we clear _aeh on L1679 below when do_thread() is executed, _aeh can
only be non-NULL when ~InstallAsyncExceptionHandshake() runs if do_thread()
was never executed.

I can add that comment above L1674 in a separate bug fix if you wish.
@robehn - do you concur that a comment here would be good?
Member
@dholmes-ora dholmes-ora 17 hours ago

It was the fact we null it and delete it that initially caused a "What the???" reaction. :) So I think I comment would be good but can wait.
Member
@robehn robehn 10 hours ago

Yes add a comment.