Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8286430

make test TEST="gtest:<sometag>" exits with error when it shouldn't

XMLWordPrintable

    • b22

        I have google-test 1.10.0. A test run running hotspot's gtests results in an always non-zero make run. For example:

        $ make LOG=debug test TEST="gtest:LogTagSet"
        [...]
        Note: Google Test filter = LogTagSet*
        [==========] Running 10 tests from 2 test suites.
        [----------] Global test environment set-up.
        [----------] 8 tests from LogTagSet
        [ RUN ] LogTagSet.defaults
        [ OK ] LogTagSet.defaults (0 ms)
        [ RUN ] LogTagSet.has_output
        [ OK ] LogTagSet.has_output (0 ms)
        [ RUN ] LogTagSet.ntags
        [ OK ] LogTagSet.ntags (0 ms)
        [ RUN ] LogTagSet.is_level
        [ OK ] LogTagSet.is_level (0 ms)
        [ RUN ] LogTagSet.level_for
        [ OK ] LogTagSet.level_for (0 ms)
        [ RUN ] LogTagSet.contains
        [ OK ] LogTagSet.contains (0 ms)
        [ RUN ] LogTagSet.label
        [ OK ] LogTagSet.label (0 ms)
        [ RUN ] LogTagSet.duplicates
        [ OK ] LogTagSet.duplicates (0 ms)
        [----------] 8 tests from LogTagSet (0 ms total)

        [----------] 2 tests from LogTagSetDescriptions
        [ RUN ] LogTagSetDescriptions.describe_vm
        [ OK ] LogTagSetDescriptions.describe_vm (0 ms)
        [ RUN ] LogTagSetDescriptions.command_line_help_vm
        [ OK ] LogTagSetDescriptions.command_line_help_vm (0 ms)
        [----------] 2 tests from LogTagSetDescriptions (102 ms total)

        [----------] Global test environment tear-down
        [==========] 10 tests from 2 test suites ran. (103 ms total)
        [ PASSED ] 10 tests.
        Finished running test 'gtest:LogTagSet/server'
        Test report is stored in build/linux-x86_64-server-fastdebug/test-results/gtest_LogTagSet_server
        /usr/bin/rm -f /disk/openjdk/upstream-sources/git/jdk-jdk/build/linux-x86_64-server-fastdebug/test-results/test-summary.txt.old 2> /dev/null
        /usr/bin/mv /disk/openjdk/upstream-sources/git/jdk-jdk/build/linux-x86_64-server-fastdebug/test-results/test-summary.txt /disk/openjdk/upstream-sources/git/jdk-jdk/build/linux-x86_64-server-fastdebug/test-results/test-summary.txt.old 2> /dev/null || true
        /usr/bin/rm -f /disk/openjdk/upstream-sources/git/jdk-jdk/build/linux-x86_64-server-fastdebug/test-support/test-last-ids.txt.old 2> /dev/null
        /usr/bin/mv /disk/openjdk/upstream-sources/git/jdk-jdk/build/linux-x86_64-server-fastdebug/test-support/test-last-ids.txt /disk/openjdk/upstream-sources/git/jdk-jdk/build/linux-x86_64-server-fastdebug/test-support/test-last-ids.txt.old 2> /dev/null || true
        echo >> /disk/openjdk/upstream-sources/git/jdk-jdk/build/linux-x86_64-server-fastdebug/test-results/test-summary.txt ==============================
        echo >> /disk/openjdk/upstream-sources/git/jdk-jdk/build/linux-x86_64-server-fastdebug/test-results/test-summary.txt Test summary
        echo >> /disk/openjdk/upstream-sources/git/jdk-jdk/build/linux-x86_64-server-fastdebug/test-results/test-summary.txt ==============================
        printf >> /disk/openjdk/upstream-sources/git/jdk-jdk/build/linux-x86_64-server-fastdebug/test-results/test-summary.txt "%2s %-49s %5s %5s %5s %5s %2s\n" " " \
            TEST TOTAL PASS FAIL ERROR " "
        echo >> /disk/openjdk/upstream-sources/git/jdk-jdk/build/linux-x86_64-server-fastdebug/test-support/test-last-ids.txt gtest_LogTagSet_server
        printf >> /disk/openjdk/upstream-sources/git/jdk-jdk/build/linux-x86_64-server-fastdebug/test-results/test-summary.txt "%2s %-49s %5d %5d %5d %5d %2s\n" ">>" "gtest:LogTagSet/server" 0 10 0 -10 "<<"
        echo >> /disk/openjdk/upstream-sources/git/jdk-jdk/build/linux-x86_64-server-fastdebug/test-results/test-summary.txt ==============================
        echo >> /disk/openjdk/upstream-sources/git/jdk-jdk/build/linux-x86_64-server-fastdebug/test-results/test-summary.txt TEST FAILURE
        /usr/bin/mkdir -p /disk/openjdk/upstream-sources/git/jdk-jdk/build/linux-x86_64-server-fastdebug/make-support
        /usr/bin/touch /disk/openjdk/upstream-sources/git/jdk-jdk/build/linux-x86_64-server-fastdebug/make-support/exit-with-error
        echo

        /usr/bin/cat /disk/openjdk/upstream-sources/git/jdk-jdk/build/linux-x86_64-server-fastdebug/test-results/test-summary.txt
        ==============================
        Test summary
        ==============================
           TEST TOTAL PASS FAIL ERROR
        >> gtest:LogTagSet/server 0 10 0 -10 <<
        ==============================
        TEST FAILURE
        echo

        gmake[3]: Leaving directory '/disk/openjdk/upstream-sources/git/jdk-jdk/make'
        gmake[2]: Leaving directory '/disk/openjdk/upstream-sources/git/jdk-jdk'
        [ -f /disk/openjdk/upstream-sources/git/jdk-jdk/build/linux-x86_64-server-fastdebug/make-support/javacservers/server.port ] && echo Stopping sjavac server && /usr/bin/touch /disk/openjdk/upstream-sources/git/jdk-jdk/build/linux-x86_64-server-fastdebug/make-support/javacservers/server.port.stop; true
        /usr/bin/date '+%Y %m %d %H %M %S' | /usr/bin/gawk '{ print $1,$2,$3,$4,$5,$6,($4*3600+$5*60+$6) }' > /disk/openjdk/upstream-sources/git/jdk-jdk/build/linux-x86_64-server-fastdebug/make-support/build-times/build_time_end_TOTAL
        /usr/bin/date '+%Y-%m-%d %H:%M:%S' > /disk/openjdk/upstream-sources/git/jdk-jdk/build/linux-x86_64-server-fastdebug/make-support/build-times/build_time_end_TOTAL_human_readable
        echo `/usr/bin/cat /disk/openjdk/upstream-sources/git/jdk-jdk/build/linux-x86_64-server-fastdebug/make-support/build-times/build_time_start_TOTAL` `/usr/bin/cat /disk/openjdk/upstream-sources/git/jdk-jdk/build/linux-x86_64-server-fastdebug/make-support/build-times/build_time_end_TOTAL` TOTAL | /usr/bin/gawk '{ F=$7; T=$14; if (F > T) { T+=3600*24 }; D=T-F; H=int(D/3600); M=int((D-H*3600)/60); S=D-H*3600-M*60; printf("%02d:%02d:%02d %s\n",H,M,S,$15); }' > /disk/openjdk/upstream-sources/git/jdk-jdk/build/linux-x86_64-server-fastdebug/make-support/build-times/build_time_diff_TOTAL
        printf -- "----- Build times -------\nStart %s\nEnd %s\n%s\n%s\n-------------------------\n" "`/usr/bin/cat /disk/openjdk/upstream-sources/git/jdk-jdk/build/linux-x86_64-server-fastdebug/make-support/build-times/build_time_start_TOTAL_human_readable`" "`/usr/bin/cat /disk/openjdk/upstream-sources/git/jdk-jdk/build/linux-x86_64-server-fastdebug/make-support/build-times/build_time_end_TOTAL_human_readable`" "`/usr/bin/ls /disk/openjdk/upstream-sources/git/jdk-jdk/build/linux-x86_64-server-fastdebug/make-support/build-times/build_time_diff_* | /usr/bin/grep -v _TOTAL | /usr/bin/xargs /usr/bin/cat | /usr/bin/sort -k 2`" "`/usr/bin/cat /disk/openjdk/upstream-sources/git/jdk-jdk/build/linux-x86_64-server-fastdebug/make-support/build-times/build_time_diff_TOTAL`" | /usr/bin/tee -a /disk/openjdk/upstream-sources/git/jdk-jdk/build/linux-x86_64-server-fastdebug/build.log
        ----- Build times -------
        Start 2022-05-09 20:24:06
        End 2022-05-09 20:24:10

        00:00:04 TOTAL
        -------------------------
        if test -f /disk/openjdk/upstream-sources/git/jdk-jdk/build/linux-x86_64-server-fastdebug/make-support/exit-with-error ; then \
            exit 1 ; \
          fi
        make[1]: *** [/disk/openjdk/upstream-sources/git/jdk-jdk/make/Init.gmk:319: main] Error 1
        make[1]: Leaving directory '/disk/openjdk/upstream-sources/git/jdk-jdk'
        make: *** [/disk/openjdk/upstream-sources/git/jdk-jdk/make/Init.gmk:186: test] Error 2

              sgehwolf Severin Gehwolf
              sgehwolf Severin Gehwolf
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Created:
                Updated:
                Resolved: