Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8286872

Refactor add/modify notification icon (TrayIcon)

    XMLWordPrintable

Details

    • b24
    • windows

    Backports

      Description

        AwtTrayIcon::WmTaskbarCreated [1] and AwtTrayIcon::_UpdateIcon [2] have duplicate code:

            BOOL result = trayIcon->SendTrayMessage(jupdate == JNI_TRUE ? NIM_MODIFY : NIM_ADD);
            // 6270114: Instructs the taskbar to behave according to the Shell version 5.0
            if (result && jupdate == JNI_FALSE) {
                trayIcon->SendTrayMessage(NIM_SETVERSION);
            }

        The only difference is the usage of jupdate which controls whether the icon is to be added or modified.

        These could be refactored into separate methods to avoid code duplication, especially in the case of adding where another method must be called.

        [1] https://github.com/openjdk/jdk/blob/7b988b31c661c6e3e58cf8ced81732e40a79d4f5/src/java.desktop/windows/native/libawt/windows/awt_TrayIcon.cpp#L477
        [2] https://github.com/openjdk/jdk/blob/7b988b31c661c6e3e58cf8ced81732e40a79d4f5/src/java.desktop/windows/native/libawt/windows/awt_TrayIcon.cpp#L796

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8291498 Refactor add/modify notification icon (TrayIcon)

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8291500 Refactor add/modify notification icon (TrayIcon)

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8296864 Refactor add/modify notification icon (TrayIcon)

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8297048 Refactor add/modify notification icon (TrayIcon)

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            relates to

            Bug - A problem which impairs or prevents the functions of the product. JDK-8286838 SendTrayMessage(NIM_ADD) returns failure in AwtTrayIcon::WmTaskbarCreated

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Closed
            links to

            Commit Commit openjdk/jdk11u-dev/954a6e48

            Commit Commit openjdk/jdk17u-dev/f29ade7e

            Commit Commit openjdk/jdk/9f562ef7

            Review Review openjdk/jdk11u-dev/1513

            Review Review openjdk/jdk17u-dev/871

            Review Review openjdk/jdk/8749

            Activity

              People

                aivanov Alexey Ivanov
                aivanov Alexey Ivanov
                Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: