Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8288020

Possible 8u backport of PRAGMA_FORMAT_MUTE_WARNINGS_FOR_GCC changes

XMLWordPrintable

    • generic
    • linux

      This is a follow-up issue to JDK-8280963 , addressing this request in its PR comments:

      https://github.com/openjdk/jdk8u-dev/pull/45#pullrequestreview-972509348

      PRAGMA_FORMAT_MUTE_WARNINGS_FOR_GCC macro suppresses the following GCC warnings:

      -Wformat
      -Wformat-nonliteral
      -Wformat-security

      Its usage was removed in jdk9 in the following issues: JDK-8042893 , JDK-8042894, JDK-8042892 , which bring extensive changes and are unlikely to be good candidates for 8u backports.

      Addressing this comment:

      https://github.com/openjdk/jdk8u-dev/pull/45#issuecomment-1145511245

      I've verified, that this macro usage in share/vm/runtime/globals.cpp (that was changed in JDK-8280963 bugfix) is not necessary, at least on GCC 11 on Fedora this file can be compiled (after macro removal) without warnings. It is not clear whether it is the case with other versions of GCC.

            Unassigned Unassigned
            akasko Alex Kasko
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: