Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8288051

Loom: Extend the compilation warning workaround in stack chunk copy

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P4 P4
    • 19
    • 19
    • hotspot
    • b26

      Current builds fail on some newer GCCs and some arches. There is already a workaround in place in one copy method, we need the workaround in another one too. I took a brief look if we could dispense with this workaround altogether, but that does not seem to be straight-forward for JDK 19 timeframe.

      ```
      * For target hotspot_variant-server_libjvm_objs_continuationFreezeThaw.o:
      In file included from /home/buildbot/shipilev-jdk/src/hotspot/share/classfile/javaClasses.inline.hpp:36,
                       from /home/buildbot/shipilev-jdk/src/hotspot/share/runtime/continuationFreezeThaw.cpp:26:
      In member function 'void stackChunkOopDesc::copy_from_stack_to_chunk(intptr_t*, intptr_t*, int)',
          inlined from 'void FreezeBase::copy_to_chunk(intptr_t*, intptr_t*, int)' at /home/buildbot/shipilev-jdk/src/hotspot/share/runtime/continuationFreezeThaw.cpp:499:34,
          inlined from 'freeze_result FreezeBase::recurse_freeze_stub_frame(frame&, frame&)' at /home/buildbot/shipilev-jdk/src/hotspot/share/runtime/continuationFreezeThaw.cpp:1168:16:
      /home/buildbot/shipilev-jdk/src/hotspot/share/oops/stackChunkOop.inline.hpp:319:9: error: argument 1 null where non-null expected [-Werror=nonnull]
        319 | memcpy(to, from, size << LogBytesPerWord);
            | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      In file included from /home/buildbot/shipilev-jdk/src/hotspot/share/utilities/globalDefinitions_gcc.hpp:35,
                       from /home/buildbot/shipilev-jdk/src/hotspot/share/utilities/globalDefinitions.hpp:35,
                       from /home/buildbot/shipilev-jdk/src/hotspot/share/metaprogramming/primitiveConversions.hpp:30,
                       from /home/buildbot/shipilev-jdk/src/hotspot/share/utilities/enumIterator.hpp:32,
                       from /home/buildbot/shipilev-jdk/src/hotspot/share/classfile/vmClassID.hpp:29,
                       from /home/buildbot/shipilev-jdk/src/hotspot/share/classfile/vmClasses.hpp:28,
                       from /home/buildbot/shipilev-jdk/src/hotspot/share/classfile/javaClasses.hpp:28,
         ... (rest of output omitted)
      ```

            shade Aleksey Shipilev
            shade Aleksey Shipilev
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: