Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8288532

additional review changes for JDK-8286830

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • P3
    • Resolution: Fixed
    • 19
    • 19
    • hotspot
    • None
    • b28

    Backports

      Description

        A couple of post-integration review comments for:

            JDK-8286830 ~HandshakeState should not touch oops

        should get resolved:


        test/hotspot/jtreg/runtime/Thread/StopAtExit.java
                };
                threadCreator.setDaemon(true);
                threadCreator.start();
                test(timeMax);
        Member
        @dcubed-ojdk dcubed-ojdk 12 days ago

        Okay, but now the test is going to execute for twice timeMax which might be
        a bit of a surprise... In particular the usage() mesg is now wrong.
        Member
        @dcubed-ojdk dcubed-ojdk 12 days ago

        Also, the @bug line is not updated with this bug ID.
        Member Author
        @pchilano pchilano 12 days ago

        Ok, we could fix this in a new bug.


        and


        test/hotspot/jtreg/runtime/Thread/SuspendAtExit.java
                };
                threadCreator.setDaemon(true);
                threadCreator.start();
                test(timeMax);
        Member
        @dcubed-ojdk dcubed-ojdk 12 days ago

        Okay, but now the test is going to execute for twice timeMax which might be
        a bit of a surprise... In particular the usage() mesg is now wrong.
        Member
        @dcubed-ojdk dcubed-ojdk 12 days ago

        Also, the @bug line is not updated with this bug ID.
        Member Author
        @pchilano pchilano 12 days ago

        Ok, we could fix this in a new bug.

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8288919 additional review changes for JDK-8286830

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8291126 additional review changes for JDK-8286830

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8291278 additional review changes for JDK-8286830

            • P3 - Major loss of function.
            • Resolved
            relates to

            Sub-task - The sub-task of the issue JDK-8288497 add support for JavaThread::is_oop_safe()

            • P2 - Crashes, loss of data, severe memory leak.
            • Resolved

            Bug - A problem which impairs or prevents the functions of the product. JDK-8286830 ~HandshakeState should not touch oops

            • P2 - Crashes, loss of data, severe memory leak.
            • Closed
            links to

            Commit Commit openjdk/jdk19/31d981e5

            Review Review openjdk/jdk19/32

            Activity

              People

                dcubed Daniel Daugherty
                dcubed Daniel Daugherty
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: