Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8289006

Cleanup from thread.hpp split

    XMLWordPrintable

Details

    • Enhancement
    • Resolution: Fixed
    • P4
    • 20
    • 20
    • hotspot
    • b04

    Description

      src/hotspot/cpu/zero/stack_zero.cpp
      #include "runtime/thread.inline.hpp"
      #include "runtime/javaThread.hpp"
      Member
      @dcubed-ojdk dcubed-ojdk 2 hours ago
      Interesting... This replacement of thread.inline.hpp to javaThread.hpp also
      has an include javaThread.inline.hpp. There are other thread.inline.hpp to
      javaThread.hpp replacements that don't add an include of javaThread.inline.hpp.

      Did you only add javaThread.inline.hpp when compilation failed?

      Member
      Author
      @coleenp coleenp 44 minutes ago
      Yes, I added javaThread.inline.hpp after compilation failed. I will remove javaThread.hpp.

      src/hotspot/share/runtime/interfaceSupport.inline.hpp
      #include "runtime/mutexLocker.hpp"
      #include "runtime/orderAccess.hpp"
      #include "runtime/os.hpp"
      #include "runtime/safepointMechanism.inline.hpp"
      #include "runtime/safepointVerifiers.hpp"
      #include "runtime/thread.hpp"
      #include "runtime/javaThread.inline.hpp"
      Member
      @dcubed-ojdk dcubed-ojdk 2 hours ago
      This is a duplicate include of the one on L33 above.

      Member
      Author
      @coleenp coleenp 44 minutes ago
      Thanks, that was unintentional. Removed.

      Attachments

        Issue Links

          Activity

            People

              coleenp Coleen Phillimore
              coleenp Coleen Phillimore
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: