Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8289091

move oop safety check from SharedRuntime::get_java_tid() to JavaThread::threadObj()

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • P3
    • 19
    • 17, 19
    • hotspot
    • b30

    Backports

      Description

        In the code review for:
            JDK-8288139 JavaThread touches oop after GC barrier is detached

        this topic came up:

        https://github.com/openjdk/jdk19/pull/21#discussion_r898495754

        Here's [~dholmes]' comment:

        > I think the oop-touching-safety check should be done in
        > threadObj() itself so that all callers are protected.

        During the review, I agreed that threadObj() was a better placement,
        but I didn't want to make that change yet because I thought it might
        result in more issues that would need to be investigated. JDK-8288139
        is about the failure due to the call to SharedRuntime::get_java_tid() and
        I wanted to focus my fix on that exact failure mode.

        This bug is for investigating moving the oop safety check from
        SharedRuntime::get_java_tid() to JavaThread::threadObj().

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8289866 move oop safety check from SharedRuntime::get_java_tid() to JavaThread::threadObj()

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8291222 move oop safety check from SharedRuntime::get_java_tid() to JavaThread::threadObj()

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8291385 move oop safety check from SharedRuntime::get_java_tid() to JavaThread::threadObj()

            • P3 - Major loss of function.
            • Resolved
            relates to

            Bug - A problem which impairs or prevents the functions of the product. JDK-8292302 Windows GetLastError value overwritten by ThreadLocalStorage::thread

            • P3 - Major loss of function.
            • Resolved

            Bug - A problem which impairs or prevents the functions of the product. JDK-8288139 JavaThread touches oop after GC barrier is detached

            • P2 - Crashes, loss of data, severe memory leak.
            • Closed
            links to

            Commit Commit openjdk/jdk19/30e134e9

            Review Review openjdk/jdk19/69

            Activity

              People

                dcubed Daniel Daugherty
                dcubed Daniel Daugherty
                Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: