Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8289274

Cleanup unnecessary null comparison before instanceof check in security modules

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Fixed
    • Icon: P5 P5
    • 20
    • None
    • security-libs
    • b06

      Update code checks both non-null and instance of a class in security classes.
      The checks and explicit casts could also be replaced with pattern matching for the instanceof operator.
      For example:
          The following code:
          public boolean equals(Object obj) {
              if (obj == null || (!(obj instanceof AccessDescription))) {
                  return false;
              }
              AccessDescription that = (AccessDescription)obj;
          Can be simplified to:
          public boolean equals(Object obj) {
              if (!(obj instanceof AccessDescription that)) {
                  return false;
              }

            aturbanov Andrey Turbanov
            aturbanov Andrey Turbanov
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: