Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8289333

Specification of method j.l.foreign.VaList::skip deserves clarification

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • P3
    • Resolution: Fixed
    • 19
    • 19
    • core-libs

    Backports

      Description

        Specificaition of method VaList::skip is rather short

        > Skips a number of elements with the given memory layouts, and advances this variable argument list's position.

        It's not perfectly clear what would for example produce the following code

                try (var session = MemorySession.openConfined()) {
                    VaList vaList = VaList.make(builder -> builder.addVarg(ValueLayout.JAVA_INT, 77)
                            .addVarg(ValueLayout.JAVA_LONG, -78),
                            session);
                    vaList.skip(ValueLayout.JAVA_DOUBLE, ValueLayout.JAVA_BOOLEAN);
                    System.out.println(vaList.nextVarg(ValueLayout.JAVA_INT));
                }

        On MacOS x86 the result is

        -78

        In the OpenJDK implementation behaves correctly, the spec of ::skip would benefit from more detailed explaination or some references or hints.

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8290186 Specification of method j.l.foreign.VaList::skip deserves clarification

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8291293 Specification of method j.l.foreign.VaList::skip deserves clarification

            • P3 - Major loss of function.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8291417 Specification of method j.l.foreign.VaList::skip deserves clarification

            • P3 - Major loss of function.
            • Resolved
            clones

            Bug - A problem which impairs or prevents the functions of the product. JDK-8289148 j.l.foreign.VaList::nextVarg call could throw IndexOutOfBoundsException or even crash the VM

            • P3 - Major loss of function.
            • Resolved
            is cloned by

            Bug - A problem which impairs or prevents the functions of the product. JDK-8291359 Specification of method j.l.foreign.VaList::skip still deserves clarification

            • P3 - Major loss of function.
            • Resolved
            links to

            Commit Commit openjdk/jdk19/3164c98f

            Review Review openjdk/jdk19/91

            Activity

              People

                jvernee Jorn Vernee
                dbessono Dmitry Bessonov
                Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: