Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8292059

Do not inline InstanceKlass::allocate_instance()

    XMLWordPrintable

Details

    • b15

    Description

      This function doesn't seem to be used on performance critical paths. Making it inline causes many extra headers to be included. E.g., we can remove the dependency on the large header classfile/javaClasses.hpp.

      open/src/hotspot$ whoincludes instanceKlass.inline.hpp
      scanning 521 instanceKlass.inline.hpp
         2 found 521 iterator.inline.hpp
         3 found 521 instanceMirrorKlass.inline.hpp
         4 found 521 instanceClassLoaderKlass.inline.hpp
         5 found 521 instanceRefKlass.inline.hpp
         6 found 521 javaClasses.inline.hpp

      (See https://github.com/iklam/tools/blob/main/headers/whoincludes.tcl )

      (TBD: need to do perf measurements)


      Attachments

        1. chart_2.png
          chart_2.png
          48 kB
        2. chart (2).png
          chart (2).png
          37 kB
        3. chart (3).png
          chart (3).png
          12 kB

        Issue Links

          Activity

            People

              azafari Afshin Zafari
              iklam Ioi Lam
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: